Add assembly case blocks#92
Merged
mattiaerre merged 4 commits intomasterfrom Jan 7, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 86.42% 93.45% +7.02%
==========================================
Files 5 5
Lines 221 336 +115
Branches 48 80 +32
==========================================
+ Hits 191 314 +123
+ Misses 28 22 -6
+ Partials 2 0 -2
Continue to review full report at Codecov.
|
Member
|
@fvictorio can you resolve the conflicts so that I can merge? thanks |
Member
Author
|
@mattiaerre Fixed! |
mattiaerre
reviewed
Jan 6, 2019
Member
mattiaerre
left a comment
mattiaerre
left a comment
There was a problem hiding this comment.
a quick comment for you @fvictorio
|
|
||
| function caseAssembly() { | ||
| assembly { | ||
| switch value |
Member
There was a problem hiding this comment.
uhm, shall we have 2 spaces to indent the "case" inside the switch?
Member
Author
There was a problem hiding this comment.
You mean that the cases should be more indented than the switch? Yeah, I agree with that, and that's what prettier does in javascript.
mattiaerre
approved these changes
Jan 7, 2019
|
|
||
| function caseAssembly() { | ||
| assembly { | ||
| switch value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #91.